BlueToolFixup: Add Skip Address Check patch for 12.4 Beta 3 and newer #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
dhinakg
previously requested changes
May 31, 2022
PMheart
reviewed
Jun 7, 2022
| static const uint8_t kSkipAddressCheckOriginal[] = | ||
| { | ||
| 0x48, 0x89, 0xF3, // mov rbx, rsi | ||
| 0xE8, 0xE3, 0xF3, 0xFE, 0xFF, // call sub_1000c5bc6 |
There was a problem hiding this comment.
Duh. The byte sequences have changed in 13.0 b1. We should mask out 0xE3, 0xF3, 0xFE, 0xFF, at a glance. However, there could be more changes as reported by @dhinakg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With macOS 12.4 Beta 3, Apple added new checks inside of
bluetoothdwhere if 2 Bluetooth devices have the same address it would throw an error:However on some modules, namely the BCM2070 and BCM2046, they would be detected twice by
bluetoothdand thus trigger this error. As these older chipsets are the only ones affected (at least with noticeable reports), the patch is configured by-btlfxallowanyaddrargument.EDIT by @PMheart: Renamed the boot argument to
-btlfxallowanyaddras requested by @dhinakg and @vit9696.The
kSkipAddressCheckpatch has been verified functional on 12.4 Beta 3, Beta 4, 12.4 Release and 12.5 Beta 1